Fix small issues resulting from merging several updates into dev#468
Merged
nikosbosse merged 1 commit intodevelopfrom Nov 20, 2023
Merged
Fix small issues resulting from merging several updates into dev#468nikosbosse merged 1 commit intodevelopfrom
nikosbosse merged 1 commit intodevelopfrom
Conversation
This was referenced Nov 18, 2023
nikosbosse
changed the title
nikosbosse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently merged a large number of PRs into the dev branch. There was, however, one previous update to correlation() only made to dev that led checks on dev to fail after the merge marathon.
Changes I had to make were pretty minor though:
I had remove a function from correlation(), check_metric(), that should not exist anymore after all the updates.
had to rename scores to scores_quantile in a failing test that got updated on dev previously, but not in all the branches we merged.