Issue #593: Rename "range" to "interval_range"#616
Merged
nikosbosse merged 6 commits intomainfrom Feb 13, 2024
Merged
Conversation
Contributor
|
its because |
9 tasks
Collaborator
Author
|
Ahh thanks that makes sense. Fix in #618. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 85.88% 85.90% +0.02%
==========================================
Files 21 21
Lines 1771 1781 +10
==========================================
+ Hits 1521 1530 +9
- Misses 250 251 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #593
As mentioned in #593, we're currently using "range" to denote the range of a prediction interval. To make this clearer, this PR replaces "range" with "interval_range".
Specifically, this PR
I don't know why the snapshot test is failing (the same issue appeared in #592). Locally, everything is fine.
Checklist
lintr::lint_package()to check for style issues introduced by my changes.