Skip to content

Issue #619: Update tests after data.table update#618

Merged
seabbs merged 1 commit intomainfrom
update-data.table
Feb 8, 2024
Merged

Issue #619: Update tests after data.table update#618
seabbs merged 1 commit intomainfrom
update-data.table

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse commented Feb 7, 2024

Description

This PR fixes #619.

As mentioned by @seabbs in #616, the recent update of data.table requires an update to our test snaps. This PR fixes this.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14a77e8) 85.77% compared to head (a84f0e1) 85.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          21       21           
  Lines        1758     1758           
=======================================
  Hits         1508     1508           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse requested a review from seabbs February 8, 2024 00:12
@nikosbosse nikosbosse changed the title Fix: Update tests after data.table update Issue #619: Update tests after data.table update Feb 8, 2024
@seabbs seabbs merged commit 124b1db into main Feb 8, 2024
@seabbs seabbs deleted the update-data.table branch February 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update of data.table on CRAN requires updating our testthat snaps

2 participants