Skip to content

Issue #765 - Delete old overviews of the default metrics#764

Merged
seabbs merged 1 commit intomainfrom
delete-old-metrics-vignette
Apr 3, 2024
Merged

Issue #765 - Delete old overviews of the default metrics#764
seabbs merged 1 commit intomainfrom
delete-old-metrics-vignette

Conversation

@nikosbosse
Copy link
Collaborator

@nikosbosse nikosbosse commented Mar 30, 2024

Description

This PR closes #765.
This PR closes #757.

As discussed in #764, the old information on the default metrics is outdated. This PR deletes this information. I'll add new info in a new PR (#762).

The PR

  • Deletes the metrics.rda and metrics-detailed.rds files (and the corresponding metrics data set
  • Deletes the create-metric-tables.R script
  • Deletes the Vignettes metric-details.Rmd and scoring-forecasts-directly.Rmd
  • Deletes a call to the metrics data from the scoringutils.Rmd Vignette
  • has unintentional(!) unrelated changes: some .Rd docs files got updates when I reinstalled the package (I think that's related to a suggested change during the last PR where we only changed the .R file, not the .Rd file)

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@codecov
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9f11180) to head (ce416d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          21       21           
  Lines        1594     1594           
=======================================
  Hits         1519     1519           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse marked this pull request as ready for review March 30, 2024 13:13
@nikosbosse nikosbosse requested a review from seabbs March 30, 2024 13:15
@nikosbosse nikosbosse changed the title Issue #764 - Delete old overviews of the default metrics Issue #763 - Delete old overviews of the default metrics Apr 3, 2024
@nikosbosse nikosbosse changed the title Issue #763 - Delete old overviews of the default metrics Issue #765 - Delete old overviews of the default metrics Apr 3, 2024
@seabbs seabbs merged commit 84cbcc9 into main Apr 3, 2024
@seabbs seabbs deleted the delete-old-metrics-vignette branch April 3, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Information related to default metrics is outdated Clean up inst/metrics/metrics-overview.Rda and inst/metrics/metrics-details.Rda

2 participants