Issue #765 - Delete old overviews of the default metrics#764
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 21 21
Lines 1594 1594
=======================================
Hits 1519 1519
Misses 75 75 ☔ View full report in Codecov by Sentry. |
seabbs
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #765.
This PR closes #757.
As discussed in #764, the old information on the default metrics is outdated. This PR deletes this information. I'll add new info in a new PR (#762).
The PR
metrics.rdaandmetrics-detailed.rdsfiles (and the correspondingmetricsdata setcreate-metric-tables.Rscriptmetric-details.Rmdandscoring-forecasts-directly.Rmdmetricsdata from thescoringutils.RmdVignette.Rddocs files got updates when I reinstalled the package (I think that's related to a suggested change during the last PR where we only changed the.Rfile, not the.Rdfile)Checklist
lintr::lint_package()to check for style issues introduced by my changes.