Conversation
seabbs
left a comment
There was a problem hiding this comment.
This looks great so far. data.table usage looks sensible though I think this now creates a copy where it didn't before (i.e every time as.data.table is called). I don't think this is a major issue though.
|
|
|
I merged new features into main and then thought it would be a good idea to fix the ensuing merge conflicts here. Maybe I should not have done that, apologies for interfering with your code. This created a test failure due to the fact that the functions for nominal forecasts I implemented modified forecasts objects in a way that triggered your checks. I made a PR targeting this PR to fix these issues: #892 |
seabbs
left a comment
There was a problem hiding this comment.
This is great. I earnt some neat stuff from this PR. As far as I am concerned, this is good to go but think we should wait for @nikosbosse to review and confirm.
|
This is great, thanks so much! Just noting that we wouldn't get any warnings when people use |
|
It feels like replacing the |
|
oo sorry Nikos I read this first as a approval and not a comment and so hit merge.... I agree as should look at the |
|
No worries, I think it's fine to merge. @Bisaloo thanks a lot, this was a really cool PR! |
This ensures that object manipulated by [ via dplyr function are still validated. See the report in #884 (comment).
This ensures that object manipulated by [ via dplyr function are still validated. See the report in #884 (comment).
This is a first draft for #816
Todo:
head()andtail()methods to avoid unnecessary warningsOpen questions / discussion points:
unclassargument inclean_forecast()?