Convert to data.table before subsetting#892
Merged
Bisaloo merged 2 commits intoinstant-invalidationfrom Aug 12, 2024
Merged
Conversation
5 tasks
seabbs
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Create custom `[.forecast()` method * Drop validation in print() * Drop forecast class where necessary * Adjust tests for earlier warnings * Add test * Write custom head and tail methods * fix merge conflict * Convert to data.table before subsetting (#892) * Add setter methods * Add basic tests for extended [.data.table() features * Do not attempt to validate atomic vectors --------- Co-authored-by: Nikos Bosse <37978797+nikosbosse@users.noreply.github.com> Co-authored-by: nikosbosse <nikosbosse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue introduced by the fact that the new assert function for nominal forecasts removes columns from a
forecastobject.