chore: remove .openapi-generator directory#20
Merged
Conversation
ctreatma
force-pushed
the
ignore-openapi-generator
branch
from
1f2360a to
721cedd
Compare
jkallem-equinix
pushed a commit
that referenced
this pull request
Aug 21, 2024
The `.openapi-generator` directory is already mentioned in `.gitignore`, but it had not been removed from the repository. In addition to removing that directory, this updates the Makefiles so that the `.openapi-generator` directory is explicitly removed whenever code is regenerated. We have to explicitly remove this directory because the `semantic-release/git` plugin [intentionally does not respect `.gitignore`](semantic-release/git#345), so these files will be re-committed on every release if they are not explicitly removed during code generation.
jkallem-equinix
pushed a commit
that referenced
this pull request
Aug 21, 2024
The `.openapi-generator` directory is already mentioned in `.gitignore`, but it had not been removed from the repository. In addition to removing that directory, this updates the Makefiles so that the `.openapi-generator` directory is explicitly removed whenever code is regenerated. We have to explicitly remove this directory because the `semantic-release/git` plugin [intentionally does not respect `.gitignore`](semantic-release/git#345), so these files will be re-committed on every release if they are not explicitly removed during code generation.
Contributor
|
This PR is included in version 0.4.0 🎉 |
ctreatma
added a commit
that referenced
this pull request
Oct 18, 2024
…#33) The `.openapi-generator` directory came back in the most recent release, despite the changes in #20. I _think_ that's because I didn't define the globs in `assets` as a nested dir, so they get evaluated separately instead of as a group. This pushes the asset globs down a level in an attempt to get the `semantic-release/git` plugin to exclude the files we want to exclude. This change is based on the following text from [the plugin docs](https://github.com/semantic-release/git?tab=readme-ov-file#assets): > Each entry in the `assets` `Array` is globbed individually. A [glob](https://github.com/micromatch/micromatch#matching-features) can be a `String` (`"dist/**/*.js"` or `"dist/mylib.js"`) or an `Array` of `String`s that will be globbed together (`["dist/**", "!**/*.css"]`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.openapi-generatordirectory is already mentioned in.gitignore, but it had not been removed from the repository. In addition to removing that directory, this updates the Makefiles so that the.openapi-generatordirectory is explicitly removed whenever code is regenerated.We have to explicitly remove this directory because the
semantic-release/gitplugin intentionally does not respect.gitignore, so these files will be re-committed on every release if they are not explicitly removed during code generation.