chore: take 2, avoid committing .openapi-generator dir during release#33
Merged
chore: take 2, avoid committing .openapi-generator dir during release#33
Conversation
Contributor
|
This PR is included in version 0.7.0 🎉 |
1 similar comment
Contributor
|
This PR is included in version 0.7.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.openapi-generatordirectory came back in the most recent release, despite the changes in #20. I think that's because I didn't define the globs inassetsas a nested dir, so they get evaluated separately instead of as a group. This pushes the asset globs down a level in an attempt to get thesemantic-release/gitplugin to exclude the files we want to exclude.This change is based on the following text from the plugin docs: