Conversation
|
Rebased to #1 |
|
Manually rebased and squashed after merge of #1 |
wouterjdb
left a comment
wouterjdb
left a comment
There was a problem hiding this comment.
Don't see anything funny - I assume the script works? 😄
berland
dismissed
wouterjdb’s stale review
Rebuild-button in Travis did it. Flaky Travis nodes is my diagnosis.
| - python: '3.5' | ||
| - python: '3.6' | ||
| - python: '3.7' | ||
| # - python: '3.7' # Missing working compile setup for sunbeam |
There was a problem hiding this comment.
Don't let this get into the main branch. Create an issue in the repository instead ;)
There was a problem hiding this comment.
A fix before merge is welcome.
subscript/sunsch.py
Outdated
|
|
||
| startdate - YYYY-MM-DD for the initial date in the simulation. This | ||
| date is not outputted and anything occuring before that | ||
| will be clipped (TODO) |
There was a problem hiding this comment.
What does the TODO imply?
There was a problem hiding this comment.
It implies unfinished business. It is not worthy of a separate Issue, so I made it more precise instead.
There was a problem hiding this comment.
One should not be afraid of making issues... The smaller the better some would say ;)
subscript/sunsch.py
Outdated
| parser = get_parser() | ||
| args = parser.parse_args() | ||
|
|
||
| # if not args.quiet and args.output != "-": |
There was a problem hiding this comment.
Removed, but it is related to the pending #5
subscript/sunsch.py
Outdated
| @@ -0,0 +1,307 @@ | |||
| # -*- coding: utf-8 -*- | |||
| """Tool for merging Schedule files. | |||
There was a problem hiding this comment.
Should all of this go into the argparser instead?
There was a problem hiding this comment.
I don't know, #7 could come up with some guidelines.
subscript/sunsch.py
Outdated
| Output will not be generated unless the produced data is valid in | ||
| Eclipse, checking provided by sunbeam/opm-parser. | ||
|
|
||
| YAML-file components: |
There was a problem hiding this comment.
The description of the yaml file could be the epilog of the argparser.
* Downgrade ubuntu version for boost/opm-common/sunbeam
3 participants
Minimal port.
File hiearchy and organization of test files is up for discussion.
No endpoint yet in setup.py, awaits other merges.