P22-803 : Added Poetry dependency manager #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeaulieu
reviewed
Jan 10, 2023
Contributor
kbeaulieu
left a comment
kbeaulieu
left a comment
There was a problem hiding this comment.
equisoft-actions/setup-python pourrait output le dependency manager. On aurait pas besoin de la job dependencies-manager.
Contributor
Author
Ça me semble avoir bien du bon sens. Je vais essayer d'updater P22-802 pour obtenir l'output. |
Contributor
Author
L'update a été effectué. python-workflows reçoit la chaîne |
kbeaulieu
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition pour ajouter la possibilité d'utiliser le gestionnaire de dépendences Poetry en plus de Pipenv.
Le fichier
python-pipenv.ymldevient doncpython-quality-checks.yml. C'est un breaking change, il faudra passer à la version v4.On vient ici ajouter une petite recherche dans
.tool-versionsafin de voir si le gestionnaire 'poetry' est présent. Ensuite, selon le cas, on vient substituer les appels pour lancer les checks à l'aide depipenv run ...ou bien depoetry run ...J'ai fait l'essai en pointant sur la branche P22-802 de setup-python et ça fonctionne tant pour pipenv que poetry.