Skip to content

P22-803 : Added Poetry dependency manager #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexisGauthierAtKronos merged 2 commits into from
Jan 18, 2023
Merged

P22-803 : Added Poetry dependency manager #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e9b0d
Added Poetry dependency manager
AlexisGauthierAtKronos Jan 6, 2023
3b55a42
Dependencies manager via output de setup-python
AlexisGauthierAtKronos Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions .github/workflows/python-pipenv.yml → .github/workflows/python-quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Python Pipenv
name: Python Quality Checks

on:
workflow_call:
Expand All @@ -20,7 +20,8 @@ jobs:
should-skip: ${{ steps.skip-check.outputs.should_skip }}

steps:
- id: skip-check
- name: Skip Check
id: skip-check
uses: fkirc/skip-duplicate-actions@v5
with:
concurrent_skipping: same_content
Expand All @@ -40,19 +41,23 @@ jobs:

setup:
name: Setup
needs: [pre-checks]
needs: [ pre-checks ]
if: ${{ needs.pre_checks.outputs.should-skip != 'true' }}
runs-on: ubuntu-latest
outputs:
dependencies-manager: ${{ steps.setup-python.outputs.dependencies-manager }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Python
id: setup-python
uses: equisoft-actions/setup-python@v1

unit-tests:
name: Unit tests
needs: [setup]
needs: [ setup ]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -63,11 +68,11 @@ jobs:

- name: Run pytest
working-directory: ${{ inputs.working-directory }}
run: pipenv run pytest -v
run: ${{ needs.setup.outputs.dependencies-manager }} run pytest -v

type-check:
name: Type check
needs: [setup]
needs: [ setup ]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -78,11 +83,11 @@ jobs:

- name: Run pytype
working-directory: ${{ inputs.working-directory }}
run: pipenv run pytype
run: ${{ needs.setup.outputs.dependencies-manager }} run pytype

code-style:
name: Code style
needs: [setup]
needs: [ setup ]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -93,4 +98,4 @@ jobs:

- name: Run pycodestyle
working-directory: ${{ inputs.working-directory }}
run: pipenv run pycodestyle --statistics --count
run: ${{ needs.setup.outputs.dependencies-manager }} run pycodestyle --statistics --count