fix: Add owner view function to manifest validation list #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrubes
reviewed
May 14, 2024
0xrubes
left a comment
0xrubes
left a comment
There was a problem hiding this comment.
LGTM. I'd say ideally, all plugins are tested via account <> plugin integration and not directly, but doesn't seem super urgent to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The example ownership plugin
SingleOwnerPlugindeclares theownerfunction in theexecutionSelectorslist, but does not assign validation to it. This leaves it non-callable from the account's fallback.Solution
Add the "always allow runtime" validation function to the
ownerfunction.Note
We didn't detect this earlier because the test
SingleOwnerPlugin.t.soltesting the plugin directly, rather than the account <> plugin integration. The newAccountTestBasewould let us spin up a quick new test file for it, but how do we want to handle this for other plugins? Is it different for ownership plugins and non-ownership plugins?