Skip to content

fix: Add owner view function to manifest validation list #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamegyed merged 1 commit into from
May 14, 2024
Merged

fix: Add owner view function to manifest validation list #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/plugins/owner/SingleOwnerPlugin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ contract SingleOwnerPlugin is BasePlugin, ISingleOwnerPlugin, IERC1271 {
functionId: uint8(FunctionId.VALIDATION_OWNER_OR_SELF),
dependencyIndex: 0 // Unused.
});
manifest.validationFunctions = new ManifestAssociatedFunction[](7);
manifest.validationFunctions = new ManifestAssociatedFunction[](8);
manifest.validationFunctions[0] = ManifestAssociatedFunction({
executionSelector: this.transferOwnership.selector,
associatedFunction: ownerValidationFunction
Expand Down Expand Up @@ -191,6 +191,10 @@ contract SingleOwnerPlugin is BasePlugin, ISingleOwnerPlugin, IERC1271 {
executionSelector: this.isValidSignature.selector,
associatedFunction: alwaysAllowRuntime
});
manifest.validationFunctions[7] = ManifestAssociatedFunction({
executionSelector: this.owner.selector,
associatedFunction: alwaysAllowRuntime
});

return manifest;
}
Expand Down
9 changes: 9 additions & 0 deletions test/account/UpgradeableModularAccount.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,15 @@ contract UpgradeableModularAccountTest is AccountTestBase {
assertEq(address(account3), address(uint160(uint256(vm.load(address(account1), slot)))));
}

function test_transferOwnership() public {
assertEq(SingleOwnerPlugin(address(account1)).owner(), owner1);

vm.prank(owner1);
SingleOwnerPlugin(address(account1)).transferOwnership(owner2);

assertEq(SingleOwnerPlugin(address(account1)).owner(), owner2);
}

// Internal Functions

function _printStorageReadsAndWrites(address addr) internal {
Expand Down