Overall straightening of the source code. by AaronV77 · Pull Request #117 · erdc/quest

AaronV77 · 2018-10-04T16:30:18Z

- Get majority of the import statments to PEP 8 standard.
- Get the enums distributed throughout the source code.
- Update the README.md
- Get api_basics and search_features_example scripts into a notebook called Getting_Started
- Get the tests working.

stickler-ci · 2018-10-04T16:30:54Z

quest/plugins/user_provider.py

                            catalog_id, x1, y1, x2, y2 = line.split()
                            properties = {}
-                            polys.append(Feature(geometry=util.bbox2poly(x1, y1, x2, y2, as_geojson=True), properties=properties, id=catalog_id))
+                            polys.append(Feature(geometry=bbox2poly(x1, y1, x2, y2, as_geojson=True), properties=properties, id=catalog_id))


E501 line too long (140 > 120 characters)

stickler-ci · 2018-10-04T16:30:54Z

quest/plugins/user_provider.py

                            catalog_id = catalog_id.split('.')[0]
                            properties = {}
-                            polys.append(Feature(geometry=util.bbox2poly(x1, y1, x2, y2, as_geojson=True), properties=properties, id=catalog_id))
+                            polys.append(Feature(geometry=bbox2poly(x1, y1, x2, y2, as_geojson=True), properties=properties, id=catalog_id))


E501 line too long (140 > 120 characters)

stickler-ci · 2018-10-04T16:30:54Z

quest/plugins/base/service_base.py

            zip_path = os.path.join(path, 'zip', filename)
            ulmo.util.download_if_new(url, zip_path, check_modified=check_modified)
-            util.logger.info('... ... zipfile saved at %s' % zip_path)
+            logger.info('... ... zipfile saved at %s' % zip_path)


F821 undefined name 'logger'

stickler-ci · 2018-10-10T18:35:19Z

quest_provider_plugins/wmts_imagery.py

                stitched_image.paste(im=incoming_image, box=(x_pixel, y_pixel))
                incoming_image.close()
+                counter += 1
+                print("Number of tiles printed: " + str(counter), end='\r')


E999 SyntaxError: invalid syntax

AaronV77 · 2018-10-16T15:34:38Z

fixes #112
fixes #108
fixes #50

…ook was fixed.

stickler-ci · 2018-10-31T19:35:34Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-10-31T19:35:34Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

examples/notebooks/WMTS_Example.ipynb

sdc50 · 2018-11-05T16:54:04Z

examples/notebooks/Watershed Delineation.ipynb

-    "fill_dataset = quest.tools.wbt_fill_depressions(\n",
-    "    dataset=elevation_raster,\n",
-    ")['datasets'][0]\n",
+    "fill_dataset = quest.tools.wbt_fill_depressions(dataset=elevation_raster)['datasets'][0]\n",


I thought this was more readable the other way.

This notebook at the time was failing for me and I was trying to get it to work on my system.

sdc50 · 2018-11-05T17:04:37Z

quest/api/datasets.py

        title = dataset

-    if 'timeseries' in file_format:
+    if static.DataType.TIMESERIES in file_format:


This shouldn't be DataType since datatype and file_format are distinct in the database. We may need to create a new static enum for file_format.

quest/api/datasets.py

quest/api/tools.py

quest_tool_plugins/whitebox/whitebox_watershed.py

sdc50 · 2018-11-05T17:38:13Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


was this test causing issues?

Yes, at the time it was and I just never uncommented it.

test/test_util_misc.py

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci · 2018-11-05T20:04:29Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:04:30Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:04:30Z

test/test_util_misc.py


 def test_get_cache_data_dir(reset_projects_dir):
-    assert quest.util.get_cache_dir() == os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    part_1 = quest.util.get_cache_dir()


F841 local variable 'part_1' is assigned to but never used

stickler-ci · 2018-11-05T20:04:30Z

test/test_util_misc.py

 def test_get_cache_data_dir(reset_projects_dir):
-    assert quest.util.get_cache_dir() == os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    part_1 = quest.util.get_cache_dir()
+    part_2 = os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))


F841 local variable 'part_2' is assigned to but never used

stickler-ci · 2018-11-05T20:04:30Z

test/test_util_misc.py

-    assert quest.util.get_cache_dir() == os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    part_1 = quest.util.get_cache_dir()
+    part_2 = os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    assert actual == expected


F821 undefined name 'actual'
F821 undefined name 'expected'

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci · 2018-11-05T20:04:43Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:04:43Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:04:43Z

test/test_util_misc.py


 def test_get_cache_data_dir(reset_projects_dir):
-    assert quest.util.get_cache_dir() == os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    part_1 = quest.util.get_cache_dir()


F841 local variable 'part_1' is assigned to but never used

stickler-ci · 2018-11-05T20:04:43Z

test/test_util_misc.py

-    assert quest.util.get_cache_dir() == os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    part_1 = quest.util.get_cache_dir()
+    expected = os.path.join(reset_projects_dir['BASE_DIR'], os.path.join('.cache', 'test_cache'))
+    assert actual == expected


F821 undefined name 'actual'

stickler-ci · 2018-11-05T20:04:55Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:04:55Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:05:08Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:05:08Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci · 2018-11-05T20:05:25Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:05:26Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:05:39Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:05:39Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:05:51Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:05:51Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci · 2018-11-05T20:06:05Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:06:05Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:06:32Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:06:32Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:06:44Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:06:44Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:06:56Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:06:56Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:07:08Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:07:08Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:07:21Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:07:21Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:07:35Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:07:35Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:08:37Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:08:37Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

stickler-ci · 2018-11-05T20:08:50Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-05T20:08:50Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

sdc50 · 2018-11-05T20:10:32Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


Suggested change

# ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),

('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),

sdc50 · 2018-11-05T20:12:58Z

quest/api/datasets.py

        title = dataset

-    if 'timeseries' in file_format:
+    if static.DataType.TIMESERIES in file_format:


Suggested change

if static.DataType.TIMESERIES in file_format:

if 'timeseries' in file_format:

coveralls · 2018-11-05T20:52:31Z

Pull Request Test Coverage Report for Build 547

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.9%) to 68.816%

Totals
Change from base Build 505:	-2.9%
Covered Lines:	4482
Relevant Lines:	6513

💛 - Coveralls

stickler-ci · 2018-11-06T14:46:09Z

test/data.py

    ('svc://usgs-nlcd:2011/5a1c31abe4b09fc93dd6381c', None),
-    ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
    ('svc://usgs-nwis:iv/01010000', {'parameter': 'gage_height', 'start': '2016-01-01', 'end': '2016-01-02'}),
+    # ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),


E501 line too long (122 > 120 characters)

stickler-ci · 2018-11-06T14:46:09Z

quest_provider_plugins/wmts_imagery.py

        width = number_of_x_tiles * TILE_SIZE
        full_image = None

+        counter = 0


F841 local variable 'counter' is assigned to but never used

quest_provider_plugins/usgs_nwis.py

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci · 2018-11-14T19:38:03Z

quest/api/tools.py

 from .metadata import get_metadata
 from .tasks import add_async
+from ..util import to_geojson
+from ..static import UriType, PluginType


F401 '..static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:03Z

quest/api/workflows.py

 from ..database import get_db, db_session
-from ..static import DatasetStatus
 from ..util import logger as log
+from ..static import DatasetStatus, UriType


F401 '..static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:03Z

quest/plugins/base/tool_base.py


-from ...static import DatasetStatus, DatasetSource
 from ...util import listify, format_json_options, uuid
+from ...static import DatasetStatus, DatasetSource, UriType


F401 '...static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:03Z

quest/plugins/user_provider.py

+from io import StringIO
+from geojson import Feature, FeatureCollection
+
+from ..static import UriType


F401 '..static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:03Z

quest_io_plugins/raster_gdal.py

-import numpy as np

+from quest.plugins import IoBase
+from quest.static import DataType


F401 'quest.static.DataType' imported but unused

stickler-ci · 2018-11-14T19:38:04Z

quest_tool_plugins/raster/rst_merge.py

+
+from quest import util
+from quest.plugins import ToolBase
+from quest.static import DataType, UriType


F401 'quest.static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:04Z

quest_tool_plugins/raster/rst_reprojection.py

-import param
+from quest import util
+from quest.plugins import ToolBase
+from quest.static import DataType, UriType


F401 'quest.static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:05Z

quest_tool_plugins/timeseries/ts_base.py

 from quest.api import get_metadata
-from quest import util
 from quest.plugins import load_plugins
+from quest.static import UriType, DataType


F401 'quest.static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:05Z

quest_tool_plugins/timeseries/ts_flow_duration.py

 from quest.api import get_metadata
-from quest import util
-from quest.util import setattr_on_dataframe
+from quest.static import DataType, UriType


F401 'quest.static.UriType' imported but unused

stickler-ci · 2018-11-14T19:38:05Z

quest_tool_plugins/whitebox/whitebox_watershed.py

-from quest.plugins import ToolBase
 from quest import util
+from quest.plugins import ToolBase
+from quest.static import DataType, UriType, GeomType


F401 'quest.static.UriType' imported but unused

* Added use of enums where relevant * Re-ordered import statements

stickler-ci reviewed Oct 4, 2018

View reviewed changes

stickler-ci reviewed Oct 10, 2018

View reviewed changes

AaronV77 added 10 commits October 31, 2018 14:03

In this commit the enums, imports, and the Watershed_Delination noteb…

4c8e805

…ook was fixed.

Stickler fixes.

e2b5481

Fixed bugs and created a new notebook.

6eea266

Removed active development lines from code.

a73fa64

Removed active development lines from code.

1154fa6

Removed active development lines from code.

8977f88

Appveyor test adjustment

c363bc8

Fixing the tests.

ec374f6

Fixing the tests.

23c7cf4

Misc changes. (Get rid of this commit in the merge)

e9e230b

stickler-ci reviewed Oct 31, 2018

View reviewed changes

AaronV77 added 2 commits October 31, 2018 14:37

Misc changes. (Get rid of this commit in the merge)

ec0ca7a

Misc changes. (Get rid of this commit in the merge)

2bca252

sdc50 requested changes Nov 5, 2018

View reviewed changes

sdc50 and others added 2 commits November 5, 2018 14:04

Update test/test_util_misc.py

3e8483a

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

Update test/test_util_misc.py

ceb9b9a

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci reviewed Nov 5, 2018

View reviewed changes

sdc50 and others added 2 commits November 5, 2018 14:04

Update test/test_util_misc.py

d049fb6

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

Update quest_tool_plugins/whitebox/whitebox_watershed.py

7f25b16

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci reviewed Nov 5, 2018

View reviewed changes

sdc50 and others added 3 commits November 5, 2018 14:05

Update quest_tool_plugins/whitebox/whitebox_watershed.py

f4f9ce3

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

Update quest/api/tools.py

47f6e0b

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

Update quest/api/datasets.py

5fb0f6c

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci reviewed Nov 5, 2018

View reviewed changes

Update examples/notebooks/WMTS_Example.ipynb

c02ae30

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci reviewed Nov 5, 2018

View reviewed changes

sdc50 reviewed Nov 5, 2018

View reviewed changes

Getting started notebook update.

8e4f10d

stickler-ci reviewed Nov 6, 2018

View reviewed changes

Misc

89af0bf

AaronV77 commented Nov 14, 2018

View reviewed changes

quest_provider_plugins/usgs_nwis.py Outdated Show resolved Hide resolved

Apply suggestions from code review

b5a7bf8

Co-Authored-By: AaronV77 <AaronV77@users.noreply.github.com>

stickler-ci reviewed Nov 14, 2018

View reviewed changes

sdc50 approved these changes Nov 19, 2018

View reviewed changes

sdc50 merged commit e92e4f4 into erdc:master Nov 19, 2018

douggallup pushed a commit to Aquaveo/quest that referenced this pull request Dec 3, 2018

Overall straightening of the source code. (erdc#117)

f96c533

* Added use of enums where relevant * Re-ordered import statements

	# ('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),
	('svc://usgs-nwis:dv/01010000', {'parameter': 'streamflow:mean:daily', 'start': '2016-01-01', 'end': '2016-01-02'}),

	if static.DataType.TIMESERIES in file_format:
	if 'timeseries' in file_format:

Conversation

AaronV77 commented Oct 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AaronV77 commented Oct 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

AaronV77 commented Oct 4, 2018 •

edited

Loading