This repository was archived by the owner on Dec 16, 2022. It is now read-only.
add sasl support#644
Closed
flyinprogrammer wants to merge 1 commit into
Closed
Conversation
| @@ -1,2 +1,77 @@ | |||
| node_modules/ | |||
| npm-debug.log | |||
| ### Node template | |||
Contributor
There was a problem hiding this comment.
We really don't need all this stuff in the gitignore. Was there something in particular that was causing you issues and wanting to be added to the repo?
Author
There was a problem hiding this comment.
i just use intellij, they have a plugin that generates from templates, this is the JetBrains and Node template.
Contributor
There was a problem hiding this comment.
Author
|
changed to 'args.sasl' and dropped my .gitignore |
|
You da man. |
|
👍 looks good to me |
|
Pull this in, now |
Author
|
if you want this code today, it can be used via docker like this:
|
|
Hmm, it's a bit unclear here where to put the sasl password, maybe change the password box text to "Password/SASL password" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works when slate/slate-irc#37 is pulled in.
You can edit the package.json if you want ?
Or wait for those merges.