sasl support#37
Closed
flyinprogrammer wants to merge 2 commits into
Closed
Conversation
|
Nice! Right of the bat I noticed there's a lot of code style (semantic) changes - these should not be a part of this PR (not only do they make reviewing a PITA, it has nothing to do with implementing SASL support). Also, additions to |
Author
|
alright so now the PR should only show 'real' code changes |
|
I managed to trim some more cosmetic changes to make this easier to review. $ git fetch git@github.com:williamboman/slate-irc feat/sasl-support && git merge --ff-only FETCH_HEAD |
Author
|
thanks dude 👍 we should probably get some eslint up in this project through - there are definitely a lot of things worth correcting. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is terrible code but it works lolz feel free to suggest how I might make this better.