Modulize#343
Merged
Pita merged 24 commits intoether:masterfrom Jan 22, 2012
Merged
Conversation
Member
|
Will let @Pita handle this pull request. Looks good to me, happy to test if required. Good work! |
Merged
Contributor
Author
|
On second thought, it would maybe be simpler to pull #344, which contains the first 9 commits, first. That branch contains all the generally useful changes and will reduce the size and complexity of this merge. |
The jQuery library does not need to be compressed; it is compressed as a consequence of being included in `pad.js`.
Default to 'node-js' only if no user agent can be found the normal way.
In the case that it is not defined, the configuration is `undefined`.
This allows the preprocessing that will restrict scope of files to be done once in Minify.
When dependencies are made explicity `pad_savedrevs.js` will be required by several of the `pad_*.js`.
Create a lazily-defined local reference for pad on initialization in each pad module in order to avoid circular dependency. At some point in the future this dependency should instead be injected into each module on initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a batch of changes isolating each file in its own module using the CommonJS convention. This sets the stage for significant amounts of code sharing amongst the client and server, which started as 1cec6227b1ca44fce036df59e1f1bc602dbc33c7, but is now branch.
This particular patch aims to be as unobtrusive as possible. The hope is that, with the explicit dependencies and interfaces enforced for each file, changes to the application will be both easier, less dangerous, and more testable than they are now.