Module Sharing#352
Merged
Pita merged 9 commits intoether:masterfrom Feb 14, 2012
Merged
Conversation
Contributor
Author
|
Bump |
Contributor
|
Can you please fix the merge conflict? |
Contributor
Author
|
Rebased |
Contributor
Author
|
Just add a change to move |
Contributor
|
I can has rebase? Sorry that you have to wait so long to get this merged |
Contributor
Author
|
Ok, it should be good now. |
This simply shares a common implementation and makes no judgements on the validity of its use. The string created is not a secure random number, so some uses of it may not be applicable.
Use it to replace code on the client and server side.
Contributor
Author
|
Rebased :) |
Contributor
|
I'm getting |
Contributor
Author
|
Ah, yes, that’s a typo. I’ll push a fix in a few. |
Contributor
Author
|
@jhollinger fixed with 9837cda. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #343 pulled, a lot of code removal can be done. This branch has the client and server use the same
AttributePool,Changeset, andcontentcollectormodules. For now the common code exists in/static/js/, which is not great, but good enough for now (a later reorganization to move code in to common, pad, ace_inner, and timeline might not be a bad idea).This change also removes the
*_clientmodules that had duplicates (domline,linestylefilter, andcssmanager). A review of the diffs showed only 2 significant additions existed in the retained modules (followAttributesineasysync2and thetopparameter togetSheetByTitleincssmanager). All the other changes were whitespace and formatting.