Skip to content

Settings: allow the existence of "password" and "hash" attributes for users. Fixes hash authentication#3792

Merged
muxator merged 10 commits intoether:developfrom
JohnMcLear:hash
Apr 1, 2020
Merged

Settings: allow the existence of "password" and "hash" attributes for users. Fixes hash authentication#3792
muxator merged 10 commits intoether:developfrom
JohnMcLear:hash

Conversation

@JohnMcLear
Copy link
Copy Markdown
Member

@JohnMcLear JohnMcLear commented Mar 30, 2020

Fixes #3681

@JohnMcLear JohnMcLear requested a review from muxator March 30, 2020 12:48
@muxator
Copy link
Copy Markdown
Contributor

muxator commented Apr 1, 2020

Clever!

There is a small logic bug, will fix.

@muxator
Settings: allow the existence of "password" and "hash" attributes for…
a581bbd 
… users.

This brings back compatibility with ep_hash_auth, which was inadvertently broken
with 28a3bba.
Based on work by John McLear.

Fixes #3681.
@muxator muxator merged commit b7ac0f7 into ether:develop Apr 1, 2020
@muxator muxator changed the title Hash fix Settings: allow the existence of "password" and "hash" attributes for users. Fixes hash authentication Apr 21, 2020
@muxator muxator added this to the 1.8.3 milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muxator muxator Awaiting requested review from muxator

Assignees

No one assigned

Labels

Bug security

Projects

None yet

Milestone

1.8.3

Development

Successfully merging this pull request may close these issues.

Hash based authentication does not work anymore

2 participants

@JohnMcLear @muxator