Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

MySQL for M1 Chips#25

Closed
pattisdr wants to merge 1 commit into
ethyca:mainfrom
pattisdr:mysql-m1
Closed

MySQL for M1 Chips#25
pattisdr wants to merge 1 commit into
ethyca:mainfrom
pattisdr:mysql-m1

Conversation

@pattisdr
Copy link
Copy Markdown
Contributor

@pattisdr pattisdr commented Nov 2, 2021

Purpose

Users with M1 chips when running integration tests locally get the error: docker: no matching manifest for linux/arm64/v8 in the manifest list entries because the MySQL image doesn't support arm64 architecture.

Changes

  • For MySQL, add --platform linux/amd64 to run an Intel image under emulation

From Docker Desktop for Apple silicon

Not all images are available for ARM64 architecture. You can add --platform linux/amd64 to run an Intel image under emulation. In particular, the mysql image is not available for ARM64. You can work around this issue by using a mariadb image.

  • Get rid of the extra docker-compose file created specifically for quickstarts since the primary integration-test docker-compose file can be used - this also opens up the quickstart to be able to be used with mysql too.

To test

Run make pytest-integration-access locally - should work for both M1 and intel chips.

Ticket

[No ticket]

Copy link
Copy Markdown
Contributor

@PSalant726 PSalant726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that these changes allow make pytest-integration-access to run locally, and that all tests pass ✅

I tested on a 2020 M1 MacBook Pro.

@pattisdr
Copy link
Copy Markdown
Contributor Author

pattisdr commented Nov 8, 2021

appreciate the review @PSalant726! ⭐

@pattisdr pattisdr closed this Nov 9, 2021
@pattisdr pattisdr mentioned this pull request Nov 9, 2021
@pattisdr
Copy link
Copy Markdown
Contributor Author

pattisdr commented Nov 9, 2021

Reopened in #54

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants