This repository was archived by the owner on Nov 30, 2022. It is now read-only.
MySQL for M1 Chips#25
Closed
pattisdr wants to merge 1 commit into
Closed
Conversation
PSalant726
approved these changes
Nov 8, 2021
Contributor
PSalant726
left a comment
There was a problem hiding this comment.
Confirming that these changes allow make pytest-integration-access to run locally, and that all tests pass ✅
I tested on a 2020 M1 MacBook Pro.
Contributor
Author
|
appreciate the review @PSalant726! ⭐ |
Merged
Contributor
Author
|
Reopened in #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Users with M1 chips when running integration tests locally get the error:
docker: no matching manifest for linux/arm64/v8 in the manifest list entriesbecause the MySQL image doesn't support arm64 architecture.Changes
From Docker Desktop for Apple silicon
integration-testdocker-compose file can be used - this also opens up the quickstart to be able to be used with mysql too.To test
Run
make pytest-integration-accesslocally - should work for both M1 and intel chips.Ticket
[No ticket]