This repository was archived by the owner on Nov 30, 2022. It is now read-only.
MySQL for M1 Chips#54
Merged
Merged
Conversation
Contributor
Author
|
Reopened from #25 to be a PR from this repo instead of my fork, while we don't have CI enabled for forks. |
Closed
Contributor
Author
|
^ Approved by Phil in #25 |
PSalant726
approved these changes
Nov 12, 2021
Contributor
PSalant726
left a comment
There was a problem hiding this comment.
Confirmed that make pytest-integration-access can run completely on my 2020 M1 MacBook Pro, but I'm seeing intermittent test failures that I wasn't seeing on @pattisdr 's fork. They're all re: Mongo, so probably unrelated to these changes?
Contributor
Author
|
thanks @PSalant726 this is unrelated, I occasionally get these mongo timeout errors locally too, usually rerunning fixes, we might need to make the mongo connection more reliable. Do you mind going ahead and merging when you're done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Users with M1 chips when running integration tests locally get the error:
docker: no matching manifest for linux/arm64/v8 in the manifest list entriesbecause the MySQL image doesn't support arm64 architecture.Changes
From Docker Desktop for Apple silicon
integration-testdocker-compose file can be used - this also opens up the quickstart to be able to be used with mysql too.To test
Run
make pytest-integration-accesslocally - should work for both M1 and intel chips.Ticket
[No ticket]