This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Add ConnectionConfig Search [#609] #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cription fields. - Add field ConnectionConfig.description - Allow ConnectionConfig.description to be updated via PATCH /connectionconfig
Contributor
Author
|
@ethyca/docs-authors small change to guides regarding how to search ConnectionConfigs |
Contributor
conceptualshark
left a comment
conceptualshark
left a comment
There was a problem hiding this comment.
👍 Docs-approved!
seanpreston
reviewed
Jun 13, 2022
|
|
||
| resp = api_client.get(url + "?search=postgres", headers=auth_header) | ||
| assert resp.status_code == 200 | ||
| assert len(resp.json()["items"]) == 2 |
Contributor
There was a problem hiding this comment.
It'd be good to assert there's some consistent ordering to this result
Contributor
Author
|
Getting this updated now and adjusting migration downrev ^ |
Conflicts: CHANGELOG.md docs/fidesops/docs/guides/database_connectors.md src/fidesops/schemas/connection_configuration/connection_config.py tests/api/v1/endpoints/test_connection_config_endpoints.py tests/api/v1/endpoints/test_policy_webhook_endpoints.py tests/fixtures/postgres_fixtures.py
Contributor
Author
|
updated; hubspot test failure unrelated ^ |
TheAndrewJackson
approved these changes
Jun 14, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add search on connectionconfig field that examines name, key, and description fields. - Add field ConnectionConfig.description - Allow ConnectionConfig.description to be updated via PATCH /connectionconfig * Add search to the guides and update changelog. * New description key returned in response. * Bump downrev. * Add ordering assertion to test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Contains schema migration; verify downrev before merging
Purpose
Allow searching
name,key, anddescriptionConnectionConfig fields. We didn't have the description field, so adding this here.Changes
ConnectionConfig.descriptionPATCH /connectionconfigsearchquery param: GET /connectionconfig/?search=postgresChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #609