Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

trigger workflows to run for pull_request event #86

Merged
NevilleS merged 11 commits into from
Nov 19, 2021
Merged

trigger workflows to run for pull_request event #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
82371f6
trigger workflows to run for pull_request_target event
Nov 18, 2021
4daa46b
change to only pull_request
Nov 18, 2021
1f7cd63
check safe to test label
Nov 19, 2021
d2057f5
what happens when a PR with the safe-to-test label is pushed to
Nov 19, 2021
e007cdb
split pr_checks into safe + unsafe
Nov 19, 2021
785162c
update names of jobs
Nov 19, 2021
478ea61
try removing push trigger
Nov 19, 2021
912f1d4
add push trigger back so we can see the check as skipped, change labe…
Nov 19, 2021
910fc09
add pull_request back to safe checks
Nov 19, 2021
3a97b35
remove push because pull_request synchronize should cover it
Nov 19, 2021
884239c
remove arbitrary change
Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions .github/workflows/pr_checks.yml → .github/workflows/safe_pr_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Run CI
on: [push]
name: CI Checks - Safe
on: [
pull_request
]

jobs:
Autoformat:
Expand Down Expand Up @@ -65,16 +67,3 @@ jobs:
uses: actions/checkout@v2
- run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner."
- run: make pytest-integration-erasure

Integration-Tests-External:
runs-on: ubuntu-latest
steps:
- run: echo "Running CI for branch ${{ github.ref }}."
- name: Check out repository code
uses: actions/checkout@v2
- run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner."
- name: Run unit tests that connect to an external db
env:
REDSHIFT_TEST_URI: ${{ secrets.REDSHIFT_TEST_URI }}
SNOWFLAKE_TEST_URI: ${{ secrets.SNOWFLAKE_TEST_URI }}
run: make pytest-external-integration
20 changes: 20 additions & 0 deletions .github/workflows/unsafe_pr_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: CI Checks - Unsafe
on:
push:
pull_request:
types: [labeled]

jobs:
Integration-Tests-External:
runs-on: ubuntu-latest
if: contains(github.event.pull_request.labels.*.name, 'run unsafe ci checks')
Copy link
Copy Markdown
Contributor Author

@seanpreston seanpreston Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition was a bit confusing to me on first pass, so to break down for anyone else:

github.event.pull_request.labels.*.name this statement is applying a filter on the github.event.pull_request.labels var, pull out a list of label names, e.g. ["safe to run", "dont merge", ...].

contains(list, "value") is then check if "value" is an element of list.

It seems simple when you put it that way, but if you don't know about the filter stage, it could look as though github.event.pull_request.labels.*.name evaluates to a string and we're checking if that string contains the PR name (which would be less robust).

https://docs.github.com/en/actions/learn-github-actions/expressions#object-filters

steps:
- run: echo "Running CI for branch ${{ github.ref }}."
- name: Check out repository code
uses: actions/checkout@v2
- run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner."
- name: Run unit tests that connect to an external db
env:
REDSHIFT_TEST_URI: ${{ secrets.REDSHIFT_TEST_URI }}
SNOWFLAKE_TEST_URI: ${{ secrets.SNOWFLAKE_TEST_URI }}
run: make pytest-external-integration