Skip to content

🐛 server: fix timestamp key typo in activity#809

Merged
cruzdanilo merged 1 commit intomainfrom
timestamp-typo
Feb 19, 2026
Merged

🐛 server: fix timestamp key typo in activity#809
cruzdanilo merged 1 commit intomainfrom
timestamp-typo

Conversation

@aguxez
Copy link
Contributor

@aguxez aguxez commented Feb 19, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 55ccd09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @aguxez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important bug in the server's activity API. A typographical error in the JSON response key for timestamps has been rectified, ensuring that consumers of the API receive correctly formatted and named data. This change improves data consistency and API reliability without altering the underlying logic or data retrieval process.

Highlights

  • Bug Fix: Corrected a typo in the activity API response, changing the key from timestamps to timestamp to accurately reflect a single timestamp value.
  • Changelog Entry: Added a new changeset file to document this patch fix for the @exactly/server package.
Changelog
  • .changeset/six-dancers-hang.md
    • Added a new changeset entry for a patch release.
  • server/api/activity.ts
    • Fixed a typo in the activity API response, changing the key timestamps to timestamp.
Activity
  • The pull request was created by aguxez.
  • A new changeset file was added to document the fix.
  • A typo in the server/api/activity.ts file was corrected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses a typo in the activity API where the timestamp field was incorrectly named timestamps when constructing the borrows array for PandaActivity. This fix ensures that the timestamp data is correctly passed to the validator and subsequent transformation logic, resolving a bug where timestamps were missing for these transaction types. The change is consistent with the defined schema and existing patterns in the codebase.

@greptile-apps
Copy link

greptile-apps bot commented Feb 19, 2026

Greptile Summary

fixed a key typo in server/api/activity.ts:261 where timestamps (plural) was used instead of timestamp (singular) when constructing panda card transaction data.

  • corrected object property from timestamps to timestamp to match the PandaActivity schema definition at line 304
  • prevented validation failures when processing panda card borrow events
  • properly documented in changeset with lowercase formatting

Confidence Score: 5/5

  • safe to merge - simple typo fix with clear impact
  • single-character fix corrects a property name to align with valibot schema definition, preventing runtime validation errors
  • no files require special attention

Important Files Changed

Filename Overview
.changeset/six-dancers-hang.md changeset file properly documents the bug fix with correct formatting
server/api/activity.ts fixed typo where timestamps was used instead of timestamp, aligning with schema definition

Last reviewed commit: 55ccd09

@sentry
Copy link

sentry bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.34%. Comparing base (6b15e0a) to head (55ccd09).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   69.11%   69.34%   +0.22%     
==========================================
  Files         208      208              
  Lines        7155     7101      -54     
  Branches     2269     2249      -20     
==========================================
- Hits         4945     4924      -21     
+ Misses       2020     1992      -28     
+ Partials      190      185       -5     
Flag Coverage Δ
e2e 52.69% <0.00%> (-16.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit 55ccd09 into main Feb 19, 2026
12 of 16 checks passed
@cruzdanilo cruzdanilo deleted the timestamp-typo branch February 19, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments