Skip to content

nucleotide-count: Remove special treatment of uracil#16

Closed
sjakobi wants to merge 1 commit intoexercism:masterfrom
sjakobi:adjust-nucleotide-count
Closed

nucleotide-count: Remove special treatment of uracil#16
sjakobi wants to merge 1 commit intoexercism:masterfrom
sjakobi:adjust-nucleotide-count

Conversation

@sjakobi
Copy link
Copy Markdown
Contributor

@sjakobi sjakobi commented Aug 17, 2014

For the related discussion see exercism/python#98.

Fixes #15.

@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Aug 17, 2014

Not sure whether the cond construct in count still is good style or whether there's something simpler like if-else…

@kytrinyx
Copy link
Copy Markdown
Member

@rubysolo do you have time to look at this one? It should be fairly straight-forward.

@rubysolo
Copy link
Copy Markdown
Contributor

I think you're right -- an if form would be better in place of the cond.  Looks good otherwise!

@sjakobi sjakobi force-pushed the adjust-nucleotide-count branch from 62325fe to 67111b1 Compare August 20, 2014 07:42
@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Aug 20, 2014

@rubysolo: Can you please rerun the tests on this?

I'm getting the following error whenever I try to run the tests:

user=> (load-file "nucleotide_count_test.clj")
java.lang.ExceptionInInitializerError (nucleotide_count_test.clj:1)

@rubysolo
Copy link
Copy Markdown
Contributor

It looks like the example file is still using the dna namespace, but the test code is looking for nucleotide_count. If you fix that, does it work for you?

@sjakobi sjakobi force-pushed the adjust-nucleotide-count branch from 67111b1 to 583feec Compare August 20, 2014 13:39
@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Aug 20, 2014

If you fix that, does it work for you?

Sadly, no.

@kytrinyx
Copy link
Copy Markdown
Member

This has gotten a bit out of date. @sjakobi would you like to rework this off of a recent master?

For the related discussion see exercism/python#98.

This also changes the namespace of the example solution from "dna" to
"nucleotide_count".
@sjakobi sjakobi force-pushed the adjust-nucleotide-count branch from 583feec to d81fdc5 Compare November 24, 2014 16:54
@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Nov 24, 2014

Sadly I still haven't made sense of that strange error above. Would someone else be willing to give this solution a test run?

@kytrinyx
Copy link
Copy Markdown
Member

@theotherzach - you've been doing clojure lately, right? Would you happen to have 15 minutes to figure out what's going on in this thing?

@theotherzach
Copy link
Copy Markdown

I'm afraid that I must report that it works on my machine

screen shot 2014-12-01 at 9 57 21 am

@kytrinyx
Copy link
Copy Markdown
Member

kytrinyx commented Dec 1, 2014

uh-oh. That means... what exactly?

@rubysolo
Copy link
Copy Markdown
Contributor

rubysolo commented Dec 1, 2014

If I copy example.clj to nucleotide_count.clj, the tests pass for me as well. I'll go ahead and merge it. Thanks @sjakobi !

@rubysolo
Copy link
Copy Markdown
Contributor

rubysolo commented Dec 1, 2014

Merged in 79ae8a6

@rubysolo rubysolo closed this Dec 1, 2014
@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Dec 1, 2014

Thanks, @theotherzach & @rubysolo, for running the tests and merging my changes!

@sjakobi sjakobi deleted the adjust-nucleotide-count branch December 1, 2014 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mention of RNA (and uracil) from nucleotide problem?

4 participants