Update nucleotide_count_test.py#98
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Aug 8, 2014
Merged
Conversation
Removed test_dna_has_no_uracil
Contributor
|
I agree that this exercise is somewhat inelegant for the reasons that you give. But removing the test case for uracil doesn't fix it IMO - now the user is left wondering how to treat uracil which gets a special mention in the README. @kytrinyx: What's your opinion here? |
Member
|
I never really liked this exercise in any language, and I haven't found a good solution to it. I think it would be OK to just remove any mention of uracil in the README and change the exercises to just be about DNA. Anything not in DNA would then throw an error. |
Contributor
Author
|
That makes sense to me. Especially seeing as the source for the problem(http://rosalind.info/problems/dna/) doesn't mention RNA either. |
sjakobi
added a commit
to sjakobi/x-common
that referenced
this pull request
Aug 7, 2014
Focus the exercise on DNA and its nucleotides A, C, G and T. The RNA-nucleotide U(dacil) shouldn't be treated specially. As discussed in exercism/python#98.
Member
|
Cool, @sjakobi updated the README, so this is ready to go. |
kytrinyx
added a commit
that referenced
this pull request
Aug 8, 2014
Update nucleotide_count_test.py
sjakobi
added a commit
to sjakobi/xjavascript
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98
sjakobi
added a commit
to sjakobi/xlisp
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xclojure
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xcoffeescript
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xcpp
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xerlang
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xlua
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xjava
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xcsharp
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xscala
that referenced
this pull request
Aug 17, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xclojure
that referenced
this pull request
Aug 20, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xclojure
that referenced
this pull request
Aug 20, 2014
For the related discussion see exercism/python#98. This also changes the namespace of the example solution from "dna" to "nucleotide_count".
kytrinyx
pushed a commit
to exercism/csharp
that referenced
this pull request
Aug 31, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/erlang
that referenced
this pull request
Aug 31, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/java
that referenced
this pull request
Aug 31, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/coffeescript
that referenced
this pull request
Aug 31, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/DEPRECATED.javascript
that referenced
this pull request
Aug 31, 2014
For the related discussion see exercism/python#98
kytrinyx
added a commit
that referenced
this pull request
Sep 2, 2014
Update nucleotide_count_test.py
kytrinyx
pushed a commit
to exercism/cpp
that referenced
this pull request
Sep 4, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/lua
that referenced
this pull request
Sep 5, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/scala
that referenced
this pull request
Oct 9, 2014
For the related discussion see exercism/python#98.
kytrinyx
pushed a commit
to exercism/common-lisp
that referenced
this pull request
Oct 19, 2014
For the related discussion see exercism/python#98.
sjakobi
added a commit
to sjakobi/xclojure
that referenced
this pull request
Nov 24, 2014
For the related discussion see exercism/python#98. This also changes the namespace of the example solution from "dna" to "nucleotide_count".
rubysolo
pushed a commit
to exercism/clojure
that referenced
this pull request
Dec 1, 2014
For the related discussion see exercism/python#98. This also changes the namespace of the example solution from "dna" to "nucleotide_count".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed test_dna_has_no_uracil for a couple of reasons
As of now the only solution I could think of was to add the following:
if nucleotype is 'U': return 0
which seems inelegant to me.
Hope this helps,
Oniwa