Skip to content

nucleotide-count: Remove special treatment of uracil#11

Merged
bressain merged 1 commit intoexercism:masterfrom
sjakobi:adjust-nucleotide-count
Aug 21, 2014
Merged

nucleotide-count: Remove special treatment of uracil#11
bressain merged 1 commit intoexercism:masterfrom
sjakobi:adjust-nucleotide-count

Conversation

@sjakobi
Copy link
Copy Markdown
Contributor

@sjakobi sjakobi commented Aug 17, 2014

For the related discussion see exercism/python#98.

@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Aug 17, 2014

Somebody please run the tests on this (or add a Travis test script) before merging.

@kytrinyx
Copy link
Copy Markdown
Member

Thanks for taking a stab at some of these. I don't know C#, so deferring to someone who does to give the go-ahead for merge.

@jwood803
Copy link
Copy Markdown
Contributor

I'll give it a go! I should have some time tonight.

@kytrinyx, this wouldn't mess up any of the submissions already done, though, would it?

@kytrinyx
Copy link
Copy Markdown
Member

Nope, though some people think that the person did it wrong, since they're seeing a new test suite and the previous one solved it against an old one.

I've basically just decided that until things settle down I'm going to not worry about changes to the test suites.

@kytrinyx
Copy link
Copy Markdown
Member

@dinkelburt Do you have time to take a look at this? It should be quick and painless.

@bressain
Copy link
Copy Markdown
Contributor

Sure, I'll have a look tonight.

bressain added a commit that referenced this pull request Aug 21, 2014
nucleotide-count: Remove special treatment of uracil
@bressain bressain merged commit 62e2e28 into exercism:master Aug 21, 2014
@sjakobi sjakobi deleted the adjust-nucleotide-count branch August 21, 2014 08:25
@jwood803
Copy link
Copy Markdown
Contributor

Sorry...I've been slacking quite a bit lately. :[

@kytrinyx
Copy link
Copy Markdown
Member

No way, that's called "real life", and is often in direct opposition to open source involvement ❤️

@jwood803
Copy link
Copy Markdown
Contributor

My main direct opposition has been the bar. 🍻

bressain added a commit that referenced this pull request Aug 31, 2014
nucleotide-count: Remove special treatment of uracil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants