nucleotide-count: Remove special treatment of uracil#10
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Aug 18, 2014
Merged
nucleotide-count: Remove special treatment of uracil#10kytrinyx merged 1 commit intoexercism:masterfrom
kytrinyx merged 1 commit intoexercism:masterfrom
Conversation
For the related discussion see exercism/python#98.
Contributor
Author
|
I'm not familiar with C++ so I hope that Travis will catch any mistake on my part. |
|
I'm not so sure that Travis has been modified to compile the xcpp unit tests. Compilation has a dependency on Boost and CMake, and I don't remember seeing PRs adding that support. @LegalizeAdulthood, does this sound about right? I cloned the repository, and compiled/ran the tests with the removed uracil check. Results are green on my end (+1). |
Contributor
|
Travis runs an integration build that compiles and runs all the C++ tests. The travis YML file has been configured to get all the dependencies. The change looks good to me. |
kytrinyx
added a commit
that referenced
this pull request
Aug 18, 2014
nucleotide-count: Remove special treatment of uracil
Member
|
Thanks! |
kytrinyx
added a commit
that referenced
this pull request
Sep 4, 2014
nucleotide-count: Remove special treatment of uracil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the related discussion see exercism/python#98.
Fixes #9.