Skip to content

Add an ISBN Verifier test case for short ISBN#239

Merged
haus merged 1 commit intoexercism:masterfrom
jgomo3:master
Jun 17, 2018
Merged

Add an ISBN Verifier test case for short ISBN#239
haus merged 1 commit intoexercism:masterfrom
jgomo3:master

Conversation

@jgomo3
Copy link
Copy Markdown
Contributor

@jgomo3 jgomo3 commented Jun 16, 2018

If your code verify the isbn length to be only less than or equal to 10, it will accept some ISBN with less than 10 digits which still satisfy other rules, being "00" a case which could be considered ISBN by some "almost correct" solutions missing this consideration.

I.e: http://exercism.io/submissions/f2fac1e79bf441e08afecd196ec0a442

@haus
Copy link
Copy Markdown
Contributor

haus commented Jun 17, 2018

Thanks for the PR @jgomo3 ! I'm happy to add this as a test case here, I wonder if you'd be open to making a PR to the shared test cases for all exercism tracks here https://github.com/exercism/problem-specifications/blob/master/exercises/isbn-verifier/canonical-data.json as well?

@haus haus merged commit 625aefe into exercism:master Jun 17, 2018
@jgomo3
Copy link
Copy Markdown
Contributor Author

jgomo3 commented Jun 17, 2018

@haus
Copy link
Copy Markdown
Contributor

haus commented Jun 18, 2018

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants