Add an ISBN Verifier test case for short ISBN#239
Merged
haus merged 1 commit intoexercism:masterfrom Jun 17, 2018
jgomo3:master
Merged
Add an ISBN Verifier test case for short ISBN#239haus merged 1 commit intoexercism:masterfrom jgomo3:master
haus merged 1 commit intoexercism:masterfrom
jgomo3:master
Conversation
Contributor
|
Thanks for the PR @jgomo3 ! I'm happy to add this as a test case here, I wonder if you'd be open to making a PR to the shared test cases for all exercism tracks here https://github.com/exercism/problem-specifications/blob/master/exercises/isbn-verifier/canonical-data.json as well? |
haus
approved these changes
Jun 17, 2018
Contributor
Author
Contributor
|
awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your code verify the isbn length to be only less than or equal to 10, it will accept some ISBN with less than 10 digits which still satisfy other rules, being "00" a case which could be considered ISBN by some "almost correct" solutions missing this consideration.
I.e: http://exercism.io/submissions/f2fac1e79bf441e08afecd196ec0a442