Add an ISBN Verifier test case for short ISBN#1251
Merged
rpottsoh merged 1 commit intoexercism:masterfrom Jun 18, 2018
jgomo3:master
Merged
Add an ISBN Verifier test case for short ISBN#1251rpottsoh merged 1 commit intoexercism:masterfrom jgomo3:master
rpottsoh merged 1 commit intoexercism:masterfrom
jgomo3:master
Conversation
If your code verify the isbn length to be only less than or equal to 10, it will accept some ISBN with less than 10 digits which still satisfy other rules, being "00" a case which could be considered ISBN by some "almost correct" solutions missing this consideration. I.e: http://exercism.io/submissions/f2fac1e79bf441e08afecd196ec0a442
rpottsoh
approved these changes
Jun 18, 2018
Member
rpottsoh
left a comment
rpottsoh
left a comment
There was a problem hiding this comment.
Interesting catch. Thanks posting this improvement.
Member
|
Thank you. Please mark that this closes #1223 using a word in https://help.github.com/articles/closing-issues-using-keywords/ . (unless someone would like to convince me that #1223 should be done with a case that has nonzero digits) |
Member
|
I like it. I agree that this PR should put #1223 to bed. |
Member
|
closes #1223 |
rpottsoh
added a commit
to rpottsoh/exercism-problem-specifications
that referenced
this pull request
Jun 18, 2018
I was too hasty when I merged exercism#1251. I missed that version had not been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your code verify the isbn length to be only less than or equal to 10, it will accept some ISBN with less than 10 digits which still satisfy other rules, being "00" a case which could be considered ISBN by some "almost correct" solutions missing this consideration.
I.e: http://exercism.io/submissions/f2fac1e79bf441e08afecd196ec0a442