Sync allergies with problem-specifications#412
Conversation
be0a644 to
e1ccb66
Compare
|
@devkabiir Would you point me in the right direction here? I've run |
|
By default I also noticed that we are using an outdated command in the P.S. Another shortcut I forgot is to use the EXERCISE=allergies dart run bin/presubmit.dart |
There was a problem hiding this comment.
-
I understand the Sync allergies with problem-specifications part of this PR.
-
I don't understand why tests had to be grouped in a top-level group? Is it because of the missing
-in the test case descriptions? as in
list when: - just eggsvslist when: just eggs -
If this is exercism wide change, would it mean all exercise test files have to be updated?
|
The change to the structure is based on the response from @Stargator here: #410 I could group them based on the groupings in the This is not an Exercism-wide change, I just want to go through the exercises in this track and update them with additional tests etc. |
e1ccb66 to
bc0d302
Compare
|
Oh my goodness, the tests are passing 🎉 The @devkabiir let me know if there's anything I can do differently to make it easier to review for the next exercises that I update. |
This uses the same structure as in word-count where the groups are referenced from within main, but defined below it.
bc0d302 to
2e7c395
Compare
devkabiir
left a comment
There was a problem hiding this comment.
Let's merge this one now. We can iterate and fine tune the test generator in subsequent PRs. The main objective is to sync the exercise with problem spec. Which is accomplished.
|
I only did the first step, which is to regenerate the existing test suite. Once that is merged I'll do the sync and regenerate. (I like to do it in two steps so that it's clear what changes the sync brings in.) |
This brings in updated instructions and an extra test.
|
I've synced and regenerated. This should be ready to go. |
This puts all the tests in the same group rather than
grouping them per the canonical-data.json structure in
problem-specifications.
In order to help make the logical groupings apparent,
the test names have been updated to be prefixed with the
group description.
To make it as easy as possible to review, I've indented
the tests two spaces extra in the first commit, and then
fixed the indentation in the second commit.
In the third commit I've synced the allergies exercise by running
This brought in updated instructions and an extra test.