Conversation
We've had some churn due to not having documented our preference. This is now documented in exercism/docs#399
There was a problem hiding this comment.
Could you add the MD004 rule to this repo's markdownlint rules? Then CI should enforce that the PR is correct, and that future PRs do not add unordered list items with the less preferred style.
problem-specifications/.markdownlint.jsonc
Lines 1 to 6 in 7012a73
I believe:
"MD004": "dash",It's run from here:
problem-specifications/.github/workflows/ci.yml
Lines 122 to 131 in 7012a73
This ensures that CI enforces the choice of bullet for the markdown files in this repository.
|
@ee7 I updated the linter, and CI is passing. I'm going to deliberately cause it to fail, to check that it's configured correctly. |
The previous commit deliberately introduced an error to check that CI caught it correctly, which it did. This reverts commit cf249d5.
|
Ok, that looks good. Thanks for your help @ee7 |
ee7
left a comment
There was a problem hiding this comment.
CI does look good - thanks for checking that it works.
I also checked independently that, with this PR, there really are no remaining unordered list items that use * or + (both are valid markers, but we only used * previously):
$ git rev-parse --short HEAD
b61cb4ac
$ rg -U '\n\s*[\*\+]{1}\s+' --type markdown
$ echo $?
1
jiegillet
left a comment
There was a problem hiding this comment.
What's not to love about a linting PR? 💛
We've had some churn due to not having documented our
preference.
This is now documented in
exercism/docs#399