phone-number: update to match canonical-data.json

[rpottsoh]

Canonical-data.json recently changed. Updating test runner and example solution to align with new json.

[kotp]

This may need to be mentioned in x-common repository, but the tests for invalid_when_11 and valid_when_11 seem contradictory, if only due to lack of message in the test. Is there a way to have a custom message reported giving the reason why 11 is invalid, sometimes?

[rpottsoh]

Of course a message can be displayed, however it is only displayed on a failure. Is that what you are after? Sent from my android device.

[rpottsoh]

@kotp instead of "invalid when 11 digits" how about "invalid when not starting with 1 and is 11 digits"? This would then seem to be balanced by "valid when 11 digits and starting with 1". If this seems reasonable I'll open an issue, or should I just submit a PR for the change?

[kotp]

You can make the change here, and potentially create that issue (or even a PR with the change) on x-common.

[kotp]

If you only make the change here, then when we do the generator we would still have the same issue potentially.

[rpottsoh]

@kotp "invalid when 11 digits" is now "invalid when 11 digits not starting with 1". Slightly different wording from earlier. OK? If you're OK with it I'll open a PR in x-common to propose a change to the canonical-data.json. Would I need to bump the version, to what?

[kotp]

"invalid when 11 digits does not start with a 1"

[rpottsoh]

I'll update this PR after exercism/problem-specifications#724 in x-common shakes out.

[rpottsoh]

@kotp, canonical-data.json has been updated. I have updated my 2nd commit to reflect the change to the json description... Should the two commits be squashed or merged as is? @rbasso was all over my PR and approved the changes, a short lived PR.

[kotp]

Yes, no point in bringing in the change if it isn't up to date.