Skip to content

phone-number: Clears up contradiction re: why 11 digits is invalid#724

Merged
rpottsoh merged 1 commit intoexercism:masterfrom
rpottsoh:phone-number
Mar 14, 2017
Merged

phone-number: Clears up contradiction re: why 11 digits is invalid#724
rpottsoh merged 1 commit intoexercism:masterfrom
rpottsoh:phone-number

Conversation

@rpottsoh
Copy link
Copy Markdown
Member

There are two tests concerning 11 digit numbers. One test says they are valid when the digits start with one. The other test states that 11 digits is invalid, but doesn't state why. The two tests seem to be contradicting each other.

@rpottsoh
Copy link
Copy Markdown
Member Author

I have to add, @kotp pointed this out to me as I was updating this exercise in the Delphi track.

There are two tests concerning 11 digit numbers.  One test says they are valid when the digits start with one.  The other test states that 11 digits is invalid, but doesn't state why.  The two tests seem to be contradicting each other.
Copy link
Copy Markdown
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

The only thing that I would change is to bump the version number to 1.0.2, according to what was discussed in #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants