Skip to content

Canonical data sync: markdown and grade-school#840

Merged
angelikatyborska merged 4 commits intomainfrom
canonical-data-sync
Aug 26, 2021
Merged

Canonical data sync: markdown and grade-school#840
angelikatyborska merged 4 commits intomainfrom
canonical-data-sync

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@angelikatyborska angelikatyborska added the x:size/small Small amount of work label Jul 25, 2021
Copy link
Copy Markdown
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


defp process(t) do
if String.starts_with?(t, "#") || String.starts_with?(t, "*") do
if (String.starts_with?(t, "#") && !String.starts_with?(t, "#######")) ||
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes my eyes bleed, so... perfect!

@angelikatyborska
Copy link
Copy Markdown
Member Author

@exercism/maintainers-admin approve+merge please, Jie already reviewed

@angelikatyborska angelikatyborska merged commit b87cd7c into main Aug 26, 2021
@angelikatyborska angelikatyborska deleted the canonical-data-sync branch August 26, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants