exercises/markdown: add extensive header parsing tests#1817
Merged
angelikatyborska merged 1 commit intoexercism:mainfrom Jul 17, 2021
gsilvapt:ft-markdown_improved_tests
Merged
exercises/markdown: add extensive header parsing tests#1817angelikatyborska merged 1 commit intoexercism:mainfrom gsilvapt:ft-markdown_improved_tests
angelikatyborska merged 1 commit intoexercism:mainfrom
gsilvapt:ft-markdown_improved_tests
Conversation
angelikatyborska
approved these changes
Jul 5, 2021
SleeplessByte
approved these changes
Jul 14, 2021
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Looks good! I have a minor cosmetic remark: the new tests use a different indentation from the existing files. @gsilvapt could you use the same indentation (2 spaces) for the new test cases?
Contributor
Author
Thank you very much! Absolutely, yes. Seems some tests below were also wrongly indented so I took the opportunity and fixed those too. |
ErikSchierboom
approved these changes
Jul 15, 2021
ErikSchierboom
requested changes
Jul 15, 2021
As discussed in issue #1812, markdown exercise would benefit with more extensive tests to ensure learners write dynamic code, capable of handling all header depths there is. To ensure their code is not too dynamic, I added the h7 level. It does not exist in the HTML specification and therefore should be equal to the input. Resolves #1812.
ErikSchierboom
approved these changes
Jul 16, 2021
Member
|
three approvals = merge 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #1812, markdown exercise would benefit with more
extensive tests to ensure learners write dynamic code, capable of
handling all header depths there is.
To ensure their code is not too dynamic, I added the h7 level. It does
not exist in the HTML specification and therefore should be equal to the
input.
Resolves #1812.