Update PangramTest.fs with another edge case#195
Merged
ErikSchierboom merged 1 commit intoexercism:masterfrom Aug 15, 2016
Merged
Update PangramTest.fs with another edge case#195ErikSchierboom merged 1 commit intoexercism:masterfrom
ErikSchierboom merged 1 commit intoexercism:masterfrom
Conversation
Looking a solutions at (http://exercism.io/tracks/fsharp/exercises/pangram) I found one that would pass all the unit test and yet be invalid since it does not check whether symbols belong to alphabet 'a'..'z'
Member
|
Excellent find! Thanks a lot for the help. Would you mind also sending a PR to the pangram.json file in the |
Member
|
Merged! 🎉 🎉 🎉 |
istepura
added a commit
to istepura/x-common
that referenced
this pull request
Aug 15, 2016
Based on exercism/fsharp#195. Test for edge case when anagram is not in target alphabet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking a solutions at (http://exercism.io/tracks/fsharp/exercises/pangram) I found one that would pass all the unit test and yet be invalid since it does not check whether symbols belong to alphabet 'a'..'z'