Update pangram.json#338
Conversation
Based on exercism/fsharp#195. Test for edge case when anagram is not in target alphabet
|
@petertseng @IanWhitney @ErikSchierboom you are the most likely to have opinions about this, I think. |
|
I feel more strongly about "the commits should be squashed before merge" than whether the test should be added. But I would support the test to be added, since it looks to be the same as that added in https://github.com/exercism/xfsharp/pull/195/files and the reasoning for it seems sound. I assume there are solutions that pass "7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog" but fail the new test? (Possibly because they remove numbers?) |
|
@petertseng Did you know that you can now squash the commits in the PR from within the GitHub interface? See this article. @kytrinyx I think this is a good addition. |
|
Should we create issues in all language repos using |
|
@tejasbubane that seems excessive for a minor test case addition. |
|
@Insti Agreed. 👍 This is an edge case anyways. |
Based on exercism/fsharp#195. Test for edge case when panagram is not in target alphabet