Skip to content

Update pangram.json#338

Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom
istepura:patch-1
Aug 18, 2016
Merged

Update pangram.json#338
ErikSchierboom merged 2 commits intoexercism:masterfrom
istepura:patch-1

Conversation

@istepura
Copy link
Copy Markdown
Contributor

@istepura istepura commented Aug 15, 2016

Based on exercism/fsharp#195. Test for edge case when panagram is not in target alphabet

Based on exercism/fsharp#195. Test for edge case when anagram is not in target alphabet
@kytrinyx
Copy link
Copy Markdown
Member

@petertseng @IanWhitney @ErikSchierboom you are the most likely to have opinions about this, I think.

@petertseng
Copy link
Copy Markdown
Member

I feel more strongly about "the commits should be squashed before merge" than whether the test should be added.

But I would support the test to be added, since it looks to be the same as that added in https://github.com/exercism/xfsharp/pull/195/files and the reasoning for it seems sound. I assume there are solutions that pass "7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog" but fail the new test? (Possibly because they remove numbers?)

@ErikSchierboom
Copy link
Copy Markdown
Member

ErikSchierboom commented Aug 16, 2016

@petertseng Did you know that you can now squash the commits in the PR from within the GitHub interface? See this article.

@kytrinyx I think this is a good addition.

@ErikSchierboom ErikSchierboom merged commit b7ee632 into exercism:master Aug 18, 2016
@tejasbubane
Copy link
Copy Markdown
Member

Should we create issues in all language repos using blazon?

@Insti
Copy link
Copy Markdown
Contributor

Insti commented Aug 20, 2016

@tejasbubane that seems excessive for a minor test case addition.

@tejasbubane
Copy link
Copy Markdown
Member

@Insti Agreed. 👍 This is an edge case anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants