Skip to content

replace 'problems' key with 'exercises' in config.json#406

Merged
petertseng merged 1 commit intoexercism:masterfrom
cgrayson:config-update
Oct 22, 2016
Merged

replace 'problems' key with 'exercises' in config.json#406
petertseng merged 1 commit intoexercism:masterfrom
cgrayson:config-update

Conversation

@cgrayson
Copy link
Copy Markdown
Contributor

see #345

@petertseng
Copy link
Copy Markdown
Member

Can I get a confirm that it is safe to delete the problems key?

Yes, it appears I can get it. exercism/DEPRECATED.x-api#137 has made it happen. Good. One last check before merge (that the order is the same.

@petertseng
Copy link
Copy Markdown
Member

Good, empty output from diff -u <(jq '.["problems"]' < config.json) <(jq '.["exercises"] | map(.["slug"])' < newconfig.json)

One last question: Should we put the slug key before the difficulty key?

@cgrayson
Copy link
Copy Markdown
Contributor Author

I listed the attributes alphabetically, as I'm used to doing in JSON, but if you prefer slug first, happy to change it.

@petertseng
Copy link
Copy Markdown
Member

I really wished I could point to an example of how it should be done, but my hope was dashed! Because #345 has it BOTH ways ("hello-world" is slug first, and then "anagram" and "forth" are alphabetical!)

My instinct was slug first since it is "the most important", but now I have no ground to stand on! @kytrinyx does this matter to you? If not I'll just take it.

@petertseng
Copy link
Copy Markdown
Member

We could just take it now and defer the decision. If we want to change it, we can change it when we make the difficulty values non-1, since all the lines will change anyway. Except the ones that stay 1.

@kytrinyx
Copy link
Copy Markdown
Member

does this matter to you

I can't decide one way or the other. My instinct says slug first, since it's the identifier for the exercise.

Let's take this and change it later if we decide we care enough!

@petertseng petertseng merged commit 8321391 into exercism:master Oct 22, 2016
@petertseng
Copy link
Copy Markdown
Member

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants