Skip to content

pov 1.1.1.3: simplify "Can find path from nodes other than x"#536

Merged
petertseng merged 2 commits intoexercism:masterfrom
petertseng:pov
May 9, 2017
Merged

pov 1.1.1.3: simplify "Can find path from nodes other than x"#536
petertseng merged 2 commits intoexercism:masterfrom
petertseng:pov

Conversation

@petertseng
Copy link
Copy Markdown
Member

This was the main change in exercism/problem-specifications#704

exercism/problem-specifications#710 is an inconsequential
change that does not affect our tests.

Two other changes in 1.1.0 that aren't exactly followed:

  • As a part of conforming to the canonical schema, trees were embedded
    into the test data, but we have no need to do it - let's reduce
    duplication, and besides we are safe from accidental mutation.
  • The "cannot trace" cases were changed to use simpler trees than
    cousins, but we would have had to introduce another tree to do that
    (one with kids and siblings). We'll stick with cousins.

@petertseng
Copy link
Copy Markdown
Member Author

I'm honestly not sure about the decisions I made, so take a look.

This was the main change in exercism/problem-specifications#704

exercism/problem-specifications#710 is an inconsequential
change that does not affect our tests.

Two other changes in 1.1.0 that aren't exactly followed:

* As a part of conforming to the canonical schema, trees were embedded
  into the test data, but we have no need to do it - let's reduce
  duplication, and besides we are safe from accidental mutation.
* The "cannot trace" cases were changed to use simpler trees than
  cousins, but we would have had to introduce another tree to do that
  (one with kids and siblings). We'll stick with cousins.
Copy link
Copy Markdown
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As a part of conforming to the canonical schema, trees were embedded into the test data, but we have no need to do it - let's reduce duplication, and besides we are safe from accidental mutation.
  • The "cannot trace" cases were changed to use simpler trees than cousins, but we would have had to introduce another tree to do that (one with kids and siblings). We'll stick with cousins.

Considering that we are not algorithmically generating the test suites, It makes sense to reuse data structures.

@petertseng petertseng merged commit 59f2dc7 into exercism:master May 9, 2017
@petertseng petertseng deleted the pov branch May 9, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants