pov 1.1.1: remove comments about trees section#710
Merged
petertseng merged 1 commit intoexercism:masterfrom Mar 12, 2017
petertseng:pov-cmt
Merged
pov 1.1.1: remove comments about trees section#710petertseng merged 1 commit intoexercism:masterfrom petertseng:pov-cmt
trees section#710petertseng merged 1 commit intoexercism:masterfrom
petertseng:pov-cmt
Conversation
Member
Author
|
Hmm, now doubting myself on whether a comment change will want a patch level bump |
We had already removed these in #704, but I forgot to remove the comments.
petertseng
changed the title
trees sectiontrees section
Member
Author
|
Changing a comment is explicitly in the list of things that want a patch-level bump. So it has been bumped. |
rbasso
approved these changes
Mar 12, 2017
petertseng
added a commit
to exercism/haskell
that referenced
this pull request
May 9, 2017
This was the main change in exercism/problem-specifications#704 exercism/problem-specifications#710 is an inconsequential change that does not affect our tests. Two other changes in 1.1.0 that aren't exactly followed: * As a part of conforming to the canonical schema, trees were embedded into the test data, but we have no need to do it - let's reduce duplication, and besides we are safe from accidental mutation. * The "cannot trace" cases were changed to use simpler trees than cousins, but we would have had to introduce another tree to do that (one with kids and siblings). We'll stick with cousins.
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Moving away from using Fixnum due to deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had already removed these in #704, but I forgot to remove the
comments.