matrix 1.1.0.6: Use 1-based indices#838
matrix 1.1.0.6: Use 1-based indices#838sshine merged 1 commit intoexercism:masterfrom petertseng:readme-1based
Conversation
|
My own opinion: Indifferent between 1 and 3. |
|
Matrix: I wonder what kind of solution we'd like to recommend for 1-indexing. Incidentally, For the current example solution using Saddle-Points: We already use I prefer 1, but I think you should fix the example solutions however you like. |
Matrix indices are usually defined so that (1, 1) is the top left entry, not (0, 0). See for example any linear algebra textbook or wikipedia: https://en.wikipedia.org/wiki/Matrix_(mathematics)#/media/File:Matrix.svg exercism/problem-specifications#1387 Matches Data.Matrix.getElem: https://hackage.haskell.org/package/matrix/docs/Data-Matrix.html#v:getElem
|
Very well. It was not too hard to translate between 1-based and 0-based in the example implementation. This PR now only does matrix for reasons related to how I think things should be squashed. |
The READMEs now have 1-based indices but the tests still have 0-based.
Before these can be merged, must decide between various solutions:
.meta/description.md. Not recommended.