Implement sgf-parsing practice exercise#2142
Conversation
andrerfcsantos
left a comment
There was a problem hiding this comment.
Thanks for this! Looks good. Left some minor comments.
|
Hi @andrerfcsantos, I would be nice if you can take a look at my PR again. I'm a bit confused about the two workflows that failed (the |
|
The configlet check was failing because of the misconfiguration of the exercises, which was the target of my suggestions. About the gradle error, now it is failing on line 118 in the file |
|
Thanks for your information. It turns out that StringBuilder.isEmpty() had just been added since Java 15. I've changed it to a zero-length check. Hope that it'll work. |
|
That was it :) The tests are now passing. I'll do a final pass over this later. |
|
I also created #2144 updating to Java 17. After that gets merged, we can try using |
andrerfcsantos
left a comment
There was a problem hiding this comment.
Let's release this!
Thanks for the delay in reviewing it.
pull request
Closes #1817. Provide test cases, starter, and reference implementations for the sgf-parsing exercise.
Note: The canonical data has been updated to remove the version (refer to this). The contributing doc should also be updated.
Reviewer Resources:
Track Policies