robot-simulator: fix test that didn't fail if nothing was thrown#406
robot-simulator: fix test that didn't fail if nothing was thrown#406tejasbubane merged 4 commits intoexercism:masterfrom jscheffner:master
Conversation
|
I also updated the example because it didn't implement this behavior. |
|
Hi @jscheffner Thanks for the PR and sorry for the delay in review. The PR looks good to me 👍 Regarding the custom exception, we had a discussion in #280. We have these string-exceptions scattered across few exercises. We would like to convert them to class-based solutions but just did not find the time to fix all of them. Would you be up to doing it for this one exercise in this PR? You can refer the circular-buffer exercise. Let me know if otherwise, this PR looks good to go. |
|
@jscheffner Did you get a chance to look at this? |
|
Sorry, I had a lot of other things on my mind. I did change it now, but I'm not sure if in #280 there was consent to use custom error classes or just error objects at all. |
|
This looks good to me 👍 |
Solves #407:
The robot-simulator exercise includes a test that should fail if in case of an invalid argument
In fact, the test only fails in the latter case. So I fixed that. I didn't touch anything else but I really wonder why anybody would throw a String instead of an Error object.