Skip to content

robot-simulator: fix test that didn't fail if nothing was thrown #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tejasbubane merged 4 commits into from
Jun 3, 2018
Merged

robot-simulator: fix test that didn't fail if nothing was thrown #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cf30fa
robot-simulator: fix test that didn't fail if nothing was thrown
jscheffner Apr 26, 2018
575fc91
robot-simulator: fix example
jscheffner Apr 26, 2018
e2d6f7f
throw custom exception if input invalid
jscheffner Jun 1, 2018
2a02846
stop skipping first test
jscheffner Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions exercises/robot-simulator/example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
export class InvalidInputError extends Error {
constructor(message) {
super();
this.message = message || 'Invalid Input';
}
}

class Robot {
constructor() {
this.coordinates = [0, 0];
Expand All @@ -9,6 +16,11 @@ class Robot {
}

orient(direction) {
const validDirections = ['north', 'south', 'east', 'west'];
if (!validDirections.includes(direction)) {
throw new InvalidInputError('Invalid Robot Bearing');
}

this.bearing = direction;
return `The robot is pointed ${direction}`;
}
Expand Down
8 changes: 3 additions & 5 deletions exercises/robot-simulator/robot-simulator.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Robot from './robot-simulator';
import { InvalidInputError } from './robot-simulator';

describe('Robot', () => {
const robot = new Robot();
Expand All @@ -13,11 +14,8 @@ describe('Robot', () => {
});

xtest('invalid robot bearing', () => {
try {
robot.orient('crood');
} catch (exception) {
expect(exception).toEqual('Invalid Robot Bearing');
}
expect(InvalidInputError.prototype).toBeInstanceOf(Error);
expect(() => robot.orient('crood')).toThrow(InvalidInputError);
});

xtest('turn right from north', () => {
Expand Down