Skip to content

Remove obsolete problems key#128

Merged
masters3d merged 1 commit intoexercism:masterfrom
ErikSchierboom:patch-1
Oct 25, 2016
Merged

Remove obsolete problems key#128
masters3d merged 1 commit intoexercism:masterfrom
ErikSchierboom:patch-1

Conversation

@ErikSchierboom
Copy link
Copy Markdown
Member

The problems key has been obsoleted as per this issue. This has already been succesfully implemented by the C#, F# and Haskell tracks, so API-wise this is a safe action.

Removing the problems key also makes it very impossible for people to only add a new exercise in the old, obsolete problems key.

The `problems` key has been obsoleted as per [this issue](exercism/DEPRECATED.x-api#137). This has already been succesfully implemented by the [C#](https://github.com/exercism/xcsharp#130), [F#](https://github.com/exercism/xfsharp#224) and [Haskell](exercism/haskell#399) tracks, so API-wise this is a safe action.

Removing the `problems` key also makes it very impossible for people to only add a new exercise in the old, obsolete `problems` key.
@pacman-bot
Copy link
Copy Markdown

41 Messages
📖 Thank you for submitting this PR.
📖

** TEST SUCCEEDED: 303 passed, 0 failed, 0 errored, 303 total ** (30845 ms)

📖 exercises/allergies/AllergiesExample.m#L23 - bitwise operator in conditional
📖 exercises/allergies/AllergiesExample.m#L25 - unnecessary else statement
📖 exercises/allergies/AllergiesTest.m#L19 - high cyclomatic complexity
📖 exercises/allergies/AllergiesTest.m#L26 - high cyclomatic complexity
📖 exercises/allergies/AllergiesTest.m#L33 - high cyclomatic complexity
📖 exercises/allergies/AllergiesTest.m#L40 - high cyclomatic complexity
📖 exercises/clock/ClockExample.m#L27 - ivar assignment outside accessors or init
📖 exercises/clock/ClockExample.m#L28 - ivar assignment outside accessors or init
📖 exercises/clock/ClockExample.m#L32 - ivar assignment outside accessors or init
📖 exercises/clock/ClockExample.m#L33 - ivar assignment outside accessors or init
📖 exercises/clock/ClockExample.m#L37 - ivar assignment outside accessors or init
📖 exercises/clock/ClockExample.m#L41 - ivar assignment outside accessors or init
📖 exercises/clock/ClockTest.m#L13 - too many methods
📖 exercises/gigasecond/GigasecondTest.m#L19 - ivar assignment outside accessors or init
📖 exercises/hello-world/HelloWorldExample.m#L7 - parameter reassignment
📖 exercises/largest-series-product/LargestSeriesProductExample.m#L8 - prefer early exits and continue
📖 exercises/largest-series-product/LargestSeriesProductTest.m#L49 - long line
📖 exercises/meetup/MeetupExample.m#L17 - high ncss method
📖 exercises/meetup/MeetupExample.m#L22 - unnecessary default statement in covered switch statement
📖 exercises/secret-handshake/SecretHandshakeExample.m#L16 - bitwise operator in conditional
📖 exercises/secret-handshake/SecretHandshakeExample.m#L20 - bitwise operator in conditional
📖 exercises/secret-handshake/SecretHandshakeExample.m#L24 - bitwise operator in conditional
📖 exercises/secret-handshake/SecretHandshakeExample.m#L28 - bitwise operator in conditional
📖 exercises/secret-handshake/SecretHandshakeExample.m#L32 - bitwise operator in conditional
📖 exercises/secret-handshake/SecretHandshakeExample.m#L34 - unnecessary else statement
📖 exercises/space-age/SpaceAgeTest.m#L24 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L29 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L35 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L41 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L47 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L53 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L59 - high cyclomatic complexity
📖 exercises/space-age/SpaceAgeTest.m#L65 - high cyclomatic complexity
📖 exercises/sum-of-multiples/SumOfMultiplesExample.m#L13 - short variable name
📖 exercises/triangle/TriangleExample.m#L5 - high cyclomatic complexity
📖 exercises/triangle/TriangleExample.m#L5 - short variable name
📖 exercises/triangle/TriangleExample.m#L5 - short variable name
📖 exercises/triangle/TriangleExample.m#L5 - short variable name
📖 exercises/triangle/TriangleExample.m#L16 - unnecessary else statement

Generated by 🚫 danger

@masters3d masters3d merged commit 4cf9da8 into exercism:master Oct 25, 2016
@ErikSchierboom ErikSchierboom deleted the patch-1 branch October 25, 2016 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants