Update MeetupTest.php#592
Closed
beqqrry-aws wants to merge 1 commit intoexercism:mainfrom
Closed
Conversation
The PR to add strict types to all PHP files (exercism#383) broke the tests for this assignment because the months are all sent as strings. This PR fixes the tests by changing the months to ints.
Collaborator
|
Can you update the example solution as well in .meta/example.php? Thanks |
Collaborator
|
It also seems like your changes fail the exercise test CI tests. Can you address those failures? |
Contributor
|
See #591 (comment) |
Collaborator
@beqqrry-aws the linting ci failure should be resolved with separate or that was merged. There are still some exercise failures which will still need to be resolved. |
Author
|
I'll take a look at addressing these issues. I was out over the new year. |
Contributor
|
@beqqrry-aws Are you willing to make this mergable? |
Author
|
Sorry, I've been slammed recently and have had little time for side projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR to add strict types to all PHP files (#383) broke the tests for this assignment because the months are all sent as strings. This PR fixes the tests by changing the months to ints.