Skip to content

Fix Meetup exercise tests#665

Merged
mk-mxp merged 1 commit intoexercism:mainfrom
mk-mxp:fix-meetup-types
Mar 27, 2024
Merged

Fix Meetup exercise tests#665
mk-mxp merged 1 commit intoexercism:mainfrom
mk-mxp:fix-meetup-types

Conversation

@mk-mxp
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp commented Mar 26, 2024

  • Test with int as specified in students file stub.
  • This requires adjusting the example solution to show it can still be done.
  • Also remove superficial strict types file headers.

Follow-up of #592 (closed by creator)

This requires adjusting the example solution to show it can still be done.

Also remove superficial strict types file headers.
@mk-mxp mk-mxp self-assigned this Mar 26, 2024
@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp added x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/small Small amount of work x:rep/small Small amount of reputation labels Mar 26, 2024
@mk-mxp mk-mxp requested a review from homersimpsons March 27, 2024 14:15
@mk-mxp
Copy link
Copy Markdown
Contributor Author

mk-mxp commented Mar 27, 2024

This change would invalidate a bunch of solutions, how can we prevent re-running tests for too old solutions? Or shouldn't we?

@homersimpsons
Copy link
Copy Markdown
Contributor

This change would invalidate a bunch of solutions, how can we prevent re-running tests for too old solutions? Or shouldn't we?

I'm not sure how we should proceed about this, @ErikSchierboom do you have any suggestion?

As this aligns the type to the student file stub, to me we should proceed with this change. It's been 3y this stub is like this, so I wouldn't expect this to break too much student code.

This also aligns with the canonical-data.json from problem specifications.

@mk-mxp
Copy link
Copy Markdown
Contributor Author

mk-mxp commented Mar 27, 2024

I just realized that this is the featured exercise for #48in24 week 32 and PHP will be one of the 3 languages of that week. So I decided to re-run all tests on community solutions to get as much "working code" there as possible.

@mk-mxp mk-mxp merged commit e12f5e1 into exercism:main Mar 27, 2024
@mk-mxp mk-mxp deleted the fix-meetup-types branch March 27, 2024 18:16
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/fix Fix an issue x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants