Skip to content

Simple-Cipher: Added additional test case#1345

Closed
darthbob88 wants to merge 1 commit intoexercism:masterfrom
darthbob88:patch-1
Closed

Simple-Cipher: Added additional test case#1345
darthbob88 wants to merge 1 commit intoexercism:masterfrom
darthbob88:patch-1

Conversation

@darthbob88
Copy link
Copy Markdown

There are more invalid keys for this exercise than just UPPER-CASE and numer1c.

There are more invalid keys for this exercise than just UPPER-CASE and numer1c.
@rpottsoh rpottsoh changed the title Added additional test case simple-cipher: Added additional test case Oct 2, 2018
@rpottsoh rpottsoh changed the title simple-cipher: Added additional test case Simple-Cipher: Added additional test case Oct 2, 2018
@rpottsoh
Copy link
Copy Markdown
Member

rpottsoh commented Oct 2, 2018

closing in favor of #1316.

"Throws an error with a key containing a punctuation mark" in #1316 I think covers the proposed case in this PR. Furthermore I think this comment along with #902. need to be considered. It seems that this can be resolved more easily by updating the wording in description.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants