Simple-Cipher: Validating Input Strings#1316
Closed
xarxziux wants to merge 1 commit intoexercism:masterfrom
Closed
Simple-Cipher: Validating Input Strings#1316xarxziux wants to merge 1 commit intoexercism:masterfrom
xarxziux wants to merge 1 commit intoexercism:masterfrom
Conversation
Expand unit tests for validating input strings as per issue exercism#1298. Three tests added covering: - Keys containing a single upper case letter. - Keys containing a space. - Keys containing a punctuation mark.
cmccandless
approved these changes
Sep 4, 2018
rpottsoh
previously approved these changes
Sep 13, 2018
rpottsoh
dismissed
their stale review
Discussion in #1298 was not finished, PR premature.
Member
This was referenced Oct 2, 2018
Contributor
|
While I think that these tests are well thought out and well implemented, they move the exercise in the wrong direction. So I am not in favor of merging them into this exercise. See #1346 (comment) for an alternate suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand unit tests for validating input strings as per issue #1298.
Three tests added covering: